This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix regrename pass to ensure renamings produce valid insns
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Chung-Lin Tang <cltang at codesourcery dot com>, Kito Cheng <kito dot cheng at gmail dot com>, Jeff Law <law at redhat dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Schmidt, Bernd - Code Sourcery" <bernds at codesourcery dot com>
- Date: Tue, 30 Jun 2015 23:16:56 +0200
- Subject: Re: [patch] fix regrename pass to ensure renamings produce valid insns
- Authentication-results: sourceware.org; auth=none
- References: <5581AA41 dot 7010201 at codesourcery dot com> <2385820 dot 32MGCG8euH at polaris> <5592E6D9 dot 5040305 at codesourcery dot com>
> Oh, yuck -- it never even occurred to me that gcc_assert could be
> disabled. I'll bet there are other bugs in GCC due to this very same
> problem of depending on its argument being executed for side-effect.
Very likely so...
> (E.g. take a look at add_stmt_to_eh_lp_fn in tree-eh.c.) Seems like
> lousy design to me especially since proper usage doesn't seem to be
> documented anywhere.
... but not this one though.
> Anyway, I think the attached patch is what's required to fix the
> instance that's my fault. OK?
Yes, it's obviously OK.
--
Eric Botcazou