This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>, Steve Ellcey <Steve dot Ellcey at imgtec dot com>, Catherine Moore <clm at codesourcery dot com>, "Richard Biener" <richard dot guenther at gmail dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, Richard Sandiford <richard dot sandiford at arm dot com>, Joseph Myers <joseph at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 29 Jun 2015 19:07:04 +0000
- Subject: RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Authentication-results: sourceware.org; auth=none
- References: <4c25620c-546c-40ae-b330-3652fe25f791 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 2 dot 10 dot 1506112002380 dot 15628 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506152042580 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506152047390 dot 9772 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506152215570 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506152157470 dot 9772 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506161240330 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506161215400 dot 4909 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506161421560 dot 5418 at eddie dot linux-mips dot org> <87mvzy4nwu dot fsf at e105548-lin dot cambridge dot arm dot com> <1434562571 dot 18552 dot 6 dot camel at ubuntu-sellcey> <alpine dot LFD dot 2 dot 11 dot 1506171910160 dot 16441 at eddie dot linux-mips dot org> <87381qw4wz dot fsf at googlemail dot com> <1434574154 dot 18552 dot 15 dot camel at ubuntu-sellcey> <6D39441BF12EF246A7ABCE6654B023532116C02D at LEMAIL01 dot le dot imgtec dot org> <alpine dot LFD dot 2 dot 11 dot 1506181244350 dot 16441 at eddie dot linux-mips dot org> <1434642321 dot 18552 dot 20 dot camel at ubuntu-sellcey> <alpine dot LFD dot 2 dot 11 dot 1506291516310 dot 31747 at eddie dot linux-mips dot org>
Maciej W. Rozycki <macro@linux-mips.org> writes:
> Richard, please have a look at my question below in a reference to your
> previous statement.
>
> On Thu, 18 Jun 2015, Steve Ellcey wrote:
>
> > OK, I checked in the prequel patch and here is a new copy of the
> > original patch based off of that (and with no HONOR_NAN checks in the
> > fma/madd instructions).
> >
> > OK for checkin?
>
> Please see below for my notes.
>
> > 2015-06-18 Steve Ellcey <sellcey@imgtec.com>
> >
> > * config.gcc (mips*-*-*): Add fused-madd.opt.
>
> Please use angle brackets as per
> <https://www.gnu.org/prep/standards/html_node/Indicating-the-Part-Changed.html>,
> i.e.:
>
> * config.gcc <mips*-*-*>: Add fused-madd.opt.
>
> There's no function or similar entity involved here and `mips*-*-*' is a
> case value like with the C language's `switch' statement where you'd use
> angle brackets too to refer to individual cases.
>
> > (*nmsub4<mode>_fastmath) Update condition.
>
> Extraneous space here.
>
> The change looks good to me otherwise.
>
> Maciej
If nobody can identify any further functional issues with this patch then
I'd like to get this committed and pursue enhancements as a second round.
Catherine, would you be happy for this to be committed on that basis?
Thanks,
Matthew
- References:
- [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd