This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [VRP] Improve value ranges for unsigned division
- From: Kugan <kugan dot vivekanandarajah at linaro dot org>
- To: Jeff Law <law at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 29 Jun 2015 10:18:47 +1000
- Subject: Re: [VRP] Improve value ranges for unsigned division
- Authentication-results: sourceware.org; auth=none
- References: <55851248 dot 3010408 at linaro dot org> <CAFiYyc0nAj_4YwgA_B6go5d-8aKLz-XnfpO6Quys_dVMdH_+Bg at mail dot gmail dot com> <558A4FE9 dot 1090201 at linaro dot org> <558C4806 dot 4040204 at redhat dot com>
On 26/06/15 04:27, Jeff Law wrote:
> On 06/24/2015 12:36 AM, Kugan wrote:
>>
>>
>> On 23/06/15 01:09, Richard Biener wrote:
>>> On Sat, Jun 20, 2015 at 9:12 AM, Kugan
>>> <kugan.vivekanandarajah@linaro.org> wrote:
>>>> As discussed in PR64130, this patch improves the VRP value ranges for
>>>> unsigned division.
>>>>
>>>> Bootstrapped and regression tested on x86_64-linux-gnu and regression
>>>> tested on arm-none-linux-gnu with no new regression.
>>>>
>>>> Is this OK for trunk?
>>>
>>> Hum, the patch is at least incomplete not covering the
>>> cmp == -1 case in the max value computation, no?
>>
>> Thanks for the review. Attached patch adds this as well.
> Please add a testcase for the cmp == -1 case too. With that addition
> this is OK for the trunk.
>
Committed as r225108 with the updated test-case after fresh bootstrap
and regression testing for x86_64-linux-gnu.
Thanks,
Kugan
> jeff
>