This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C PATCH to use is_global_var

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 24 Jun 2015 10:51:10 -0600
Subject: Re: C PATCH to use is_global_var
Authentication-results: sourceware.org; auth=none
References: <20150624102245 dot GV10139 at redhat dot com>

On 06/24/2015 04:22 AM, Marek Polacek wrote:

This patch makes the C FE use the predicate is_global_var in place of direct

   TREE_STATIC (t) || DECL_EXTERNAL (t)

It should improve readability a bit and make predicates easier to follow.

Bootstrapped/regtested on x86_64-linux, ok for trunk?

2015-06-24  Marek Polacek  <polacek@redhat.com>

	* c-common.c (handle_no_reorder_attribute): Use is_global_var.
	* cilk.c (extract_free_variables): Likewise.

	* c-decl.c: Use is_global_var throughout.
	* c-parser.c: Likewise.
	* c-typeck.c: Likewise.

OK. If you find other places where you can use is_global_var to replacethe TREE_STATIC || DECL_EXTERNAL check, consider them pre-approved.


jeff

References:
- C PATCH to use is_global_var
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]