This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix regrename pass to ensure renamings produce valid insns
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Chung-Lin Tang <cltang at codesourcery dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Schmidt, Bernd - Code Sourcery" <bernds at codesourcery dot com>
- Date: Wed, 24 Jun 2015 18:48:34 +0200
- Subject: Re: [patch] fix regrename pass to ensure renamings produce valid insns
- Authentication-results: sourceware.org; auth=none
- References: <5581AA41 dot 7010201 at codesourcery dot com> <1919634 dot FPIRa5rfyH at polaris> <558A0130 dot 9010202 at codesourcery dot com>
> Like this? I tested this on nios2 and x86_64-linux-gnu, as before, plus
> built for aarch64-linux-gnu and ran the gcc testsuite.
Yes, the patch is OK, modulo...
> The c6x back end also calls regrename_do_replace. I am not set up to
> build or test on that target, and Bernd told me off-list that it would
> never fail on that target anyway so I have left that code alone.
... Bernd has obviously the final say here, but it would be better to add an
assertion that it indeed did not fail (just build the cc1 as a sanity check).
Thanks for adding the missing head comment to regrename_do_replace.
--
Eric Botcazou