This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: DIsable reorder_blocks_and_partition for DWARF2 unwinding

From: Jeff Law <law at redhat dot com>
To: Dehao Chen <dehao at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: David Li <davidxl at google dot com>, Jan Hubicka <hubicka at ucw dot cz>
Date: Tue, 23 Jun 2015 17:21:53 -0600
Subject: Re: DIsable reorder_blocks_and_partition for DWARF2 unwinding
Authentication-results: sourceware.org; auth=none
References: <CAO2gOZUpyzR1-Uh7mZbNptGiQvTifqtw+GapUBM-gU_b1d5SAQ at mail dot gmail dot com>

On 06/23/2015 04:18 PM, Dehao Chen wrote:

This patch disables reorder_blocks_and_partition for DWARF2 unwinding.
This is causing an internal application to segfault when built with
AutoFDO+EH. Unfortunately, I don't have a small reproducible. But from
the comment above the code, I do not see why UI_DWARF2 will survive
the issue. Any comments?

Bootstrapped and test on-going.

OK for trunk?

Thanks,
Dehao

ChangeLog:

2015-06-23  Dehao Chen  <dehao@google.com>

* opts.c(finish_options): Disable reorder_blocks_and_partition for DWARF2.

This seems wrong to me -- shouldn't we be looking at what went wrongwith the application and fixing whatever interaction between dwarf2unwinding and reorder_and_partition?


jeff

References:
- DIsable reorder_blocks_and_partition for DWARF2 unwinding
  - From: Dehao Chen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]