This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ARM] Fix PR middle-end/65958
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Jun 2015 21:02:30 +0200
- Subject: Re: [ARM] Fix PR middle-end/65958
- Authentication-results: sourceware.org; auth=none
- References: <1478566 dot ZKXszbaoG4 at polaris> <55814968 dot 9060908 at foss dot arm dot com>
> Please mark this pattern with (set_attr "type" "multiple").
Done.
> While I suspect that stack probing is done before any insns with invalid
> constants in the function, it would be better to model the length of
> this insn so that the minipool logic is not confused later in terms of
> placement of constant pools.
OK, I can put an upper bound.
> Shouldn't the pattern contain clobbers for the CC register or is that
> unnecessary for the same reason as above ?
That's unnecessary, UNSPEC_VOLATILEs are optimization barriers so no CC-
related instructions can be moved up to before the instruction.
> Additionally please add
>
> (set_attr "conds" "clob")
>
> to this pattern so that the CCFSM state machine doesn't go awry in any
> of these cases.
Also done.
--
Eric Botcazou