This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: Richard Sandiford <richard dot sandiford at arm dot com>, Joseph Myers <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Catherine Moore <clm at codesourcery dot com>, Matthew Fortune <matthew dot fortune at imgtec dot com>
- Date: Wed, 17 Jun 2015 19:17:53 +0100 (BST)
- Subject: Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Authentication-results: sourceware.org; auth=none
- References: <4c25620c-546c-40ae-b330-3652fe25f791 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 2 dot 10 dot 1506112002380 dot 15628 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506152042580 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506152047390 dot 9772 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506152215570 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506152157470 dot 9772 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506161240330 dot 5418 at eddie dot linux-mips dot org> <alpine dot DEB dot 2 dot 10 dot 1506161215400 dot 4909 at digraph dot polyomino dot org dot uk> <alpine dot LFD dot 2 dot 11 dot 1506161421560 dot 5418 at eddie dot linux-mips dot org> <87mvzy4nwu dot fsf at e105548-lin dot cambridge dot arm dot com> <1434562571 dot 18552 dot 6 dot camel at ubuntu-sellcey>
On Wed, 17 Jun 2015, Steve Ellcey wrote:
> Well, I don't mind removing the HONOR_NAN checks from the MIPS code in
> my patch but I am not sure I can do a patch to remove it from the shared
> code. I see about 80 HONOR_NAN checks in the shared code and I am not
> sure which ones can and cannot be removed.
FAOD I meant to remove the checks globally throughout MIPS target code
only.
> Is there any reason why my patch (minus the HONOR_NAN checks) would have
> to wait for the other changes?
Because it combines two functionally independent changes:
1. HONOR_NAN check removal.
2. FMA support addition.
Worse yet, syntactically overlapping, so that e.g. it's impossible to
bisect the cause of any possible regression caused without reconstructing
the two changes from the patch committed if it went in as a single change.
Maciej
- References:
- [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd
- Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd