This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR64164] drop copyrename, integrate into expand
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, David Edelsohn <dje dot gcc at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "William J. Schmidt" <wschmidt at linux dot vnet dot ibm dot com>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- Date: Tue, 9 Jun 2015 22:25:43 +0200
- Subject: Re: [PR64164] drop copyrename, integrate into expand
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvny=QAQFSC38Avh1F=H+mc5inGyEnzVAh0Y5wYfJMxDRL6g at mail dot gmail dot com> <or3820ybvq dot fsf at livre dot home> <orr3pkwsji dot fsf at livre dot home>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jun 09, 2015 at 05:11:45PM -0300, Alexandre Oliva wrote:
> On Jun 9, 2015, Alexandre Oliva <aoliva@redhat.com> wrote:
>
> > On Jun 9, 2015, David Edelsohn <dje.gcc@gmail.com> wrote:
> >> This also broke bootstrap on PPC64 LE Linux with the same error.
>
> > Thanks for your reports. I'm looking into the problem.
>
> > I'd appreciate a preprocessed testcase from either of you to confirm the
> > fix, if not to help debug it.
>
> The first potential source for this problem that jumped at me would be
> silenced with this change:
>
> diff --git a/gcc/function.c b/gcc/function.c
> index 8bcc352..9201ed9 100644
> --- a/gcc/function.c
> +++ b/gcc/function.c
> @@ -2974,7 +2974,8 @@ assign_parm_setup_block (struct assign_parm_data_all *all,
> stack_parm = copy_rtx (stack_parm);
> if (GET_MODE_SIZE (GET_MODE (entry_parm)) == size)
> PUT_MODE (stack_parm, GET_MODE (entry_parm));
> - set_mem_attributes (stack_parm, parm, 1);
> + if (GET_CODE (stack_parm) == MEM)
FYI, this is preferrably if (MEM_P (stack_parm)) these days.
> + set_mem_attributes (stack_parm, parm, 1);
> }
Jakub