This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Date: Thu, 4 Jun 2015 21:05:51 +0000
- Subject: Re: [libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)
- Authentication-results: sourceware.org; auth=none
- References: <20150604141441 dot GL2756 at redhat dot com>
On Thu, 4 Jun 2015, Marek Polacek wrote:
> This patch fixes two issues in locations with offsets that these two
> new tests revealed:
> 1) we should check the return value of location_get_source_line;
> 2) linemap_position_for_loc_and_offset can be confused if a location
> is in a different map than it expects it to be. Proper fix is unknown
> yet, so removing two asserts and just giving up is best for now.
> Manuel said he'd take a look at this later.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
OK in the absence of objections from Dodji as line map maintainer within
48 hours.
--
Joseph S. Myers
joseph@codesourcery.com