This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests
- From: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 1 Jun 2015 11:20:29 +0100
- Subject: Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests
- Authentication-results: sourceware.org; auth=none
- References: <20150601083934 dot GH10247 at tucnak dot redhat dot com>
- Reply-to: vogt at linux dot vnet dot ibm dot com
On Mon, Jun 01, 2015 at 10:39:34AM +0200, Jakub Jelinek wrote:
> always_inline attribute is meaningful only for functions declared
> inline, and the compiler even warns about this, so it is unclear
> to me why the tests are attempting to use that.
Since Gcc emits just a cryptic warning and not an error, many
people seem to have missed that always_inline's behaviour is
undefined for functions without "inline". There are many more
test cases that forget the "inline" and filter the warning with
"-Wno-attributes". I'll post an add-on patch later after testing
it.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany