This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] testsuite enable PIE tests on FreeBSD

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Jeff Law <law at redhat dot com>, Andreas Tobler <andreast-list at fgznet dot ch>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 28 May 2015 13:23:15 +0200
Subject: Re: [patch] testsuite enable PIE tests on FreeBSD
Authentication-results: sourceware.org; auth=none
References: <555CBE89 dot 5020500 at fgznet dot ch> <555CEEEE dot 50902 at redhat dot com>

Hi!

On Wed, 20 May 2015 14:30:38 -0600, Jeff Law <law@redhat.com> wrote:
> On 05/20/2015 11:04 AM, Andreas Tobler wrote:
> > the attached patch enables some PIE tests on FreeBSD.

> Wouldn't it be better to remove the target selector and instead add:
> 
> /* { dg-require-effective-target pie } */
> 
> In each of those tests?

(Got committed to trunk in r223498.)  Thanks!  I wanted to suggest
something along the same lines, because:

> While the net effect is the same today, it means there's only one place 
> to change if another x86 target gains PIE support in the future.

GNU Hurd got it, too.  :-)


GrÃÃe,
 Thomas

Attachment: signature.asc
Description: PGP signature

References:
- [patch] testsuite enable PIE tests on FreeBSD
  - From: Andreas Tobler
- Re: [patch] testsuite enable PIE tests on FreeBSD
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]