This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, RFC] New memory usage statistics infrastructure


Hi!

On Fri, 15 May 2015 16:38:40 +0200, Martin LiÅka <mliska@suse.cz> wrote:
> Following patch attempts to rewrite memory reports for GCC's internal allocations
> [...]

(Got commtited to trunk in r223748.)

> 	* hash-map-traits.h: New file.

In that one you added a copyright/licensing header, but...

> 	* mem-stats-traits.h: New file.
> 	* mem-stats.h: New file.

... in these two you didn't (but should):

> --- /dev/null
> +++ b/gcc/hash-map-traits.h
> @@ -0,0 +1,104 @@
> +/* A hash map traits.
> +   Copyright (C) 2015 Free Software Foundation, Inc.
> +
> +This file is part of GCC.
> +
> +GCC is free software; you can redistribute it and/or modify it under
> +the terms of [...]

> --- /dev/null
> +++ b/gcc/mem-stats-traits.h
> @@ -0,0 +1,20 @@
> +#ifndef GCC_MEM_STATS_TRAITS_H
> +#define GCC_MEM_STATS_TRAITS_H
> +
> +/* Memory allocation origin.  */
> +enum mem_alloc_origin
> +{
> +  HASH_TABLE,
> +  HASH_MAP,
> +  HASH_SET,
> +  VEC,
> +  BITMAP,
> +  GGC,
> +  MEM_ALLOC_ORIGIN_LENGTH
> +};
> +
> +/* Verbose names of the memory allocation origin.  */
> +static const char * mem_alloc_origin_names[] = { "Hash tables", "Hash maps", "Hash sets",
> +  "Heap vectors", "Bitmaps", "GGC memory" };
> +
> +#endif // GCC_MEM_STATS_TRAITS_H

> --- /dev/null
> +++ b/gcc/mem-stats.h
> @@ -0,0 +1,535 @@
> +#ifndef GCC_MEM_STATS_H
> +#define GCC_MEM_STATS_H
> +
> +#include "hash-map-traits.h"
> +[...]


GrÃÃe,
 Thomas

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]