This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Fix PR66168: ICE due to incorrect invariant register info
- From: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- To: "'Jeff Law'" <law at redhat dot com>, "'Steven Bosscher'" <stevenb dot gcc at gmail dot com>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 May 2015 10:15:24 +0800
- Subject: RE: [PATCH] Fix PR66168: ICE due to incorrect invariant register info
- Authentication-results: sourceware.org; auth=none
- References: <000001d0921d$003785d0$00a69170$ at arm dot com> <CABu31nMgSwQ3=6wuB5uYgk8T8kJjgVcKN2MwWdsStYP9Q9E9Tg at mail dot gmail dot com> <000101d092de$cabd1a10$60374e30$ at arm dot com> <000201d0936a$6e361940$4aa24bc0$ at arm dot com> <555FB398 dot 2060000 at redhat dot com> <000401d09689$cb6c1b10$62445130$ at arm dot com> <5565E195 dot 20006 at redhat dot com>
> From: Jeff Law [mailto:law@redhat.com]
> Sent: Wednesday, May 27, 2015 11:24 PM
> Ah, OK. I was looking at the code prior to the call for
> can_move_invariant_reg in move_invariant_reg which implies that DEST
> can
> be a subreg, but REG can not.
>
> But with that check in can_move_invariant_reg obviously won't matter.
> It feels like we've likely got some dead code here, but that can be a
> follow-up if you want to pursue.
Are you referring to the subreg code? It's used at the end of the function:
inv->reg = reg;
inv->orig_regno = regno;
>
> OK for the trunk.
Thanks, committed.
Best regards,
Thomas