This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Mikael Morin <mikael dot morin at sfr dot fr>
- Cc: Andre Vehreschild <vehre at gmx dot de>, Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 27 May 2015 14:09:48 -0700
- Subject: Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiJ66iHS3J9d9H+f6e=ZeSO60ktDat-4e5TAjeO9W8oZFg at mail dot gmail dot com> <20150523195252 dot 22647b46 at vepi2> <CAGkQGiJzt4y7n4KMgO+Z9ooh2HPgj=SG5Vm9wanJeGMZoxePbg at mail dot gmail dot com> <CAGkQGiK9toG47ywxaWYOWpvHOEA98btpYPXFTx8HN4=82kzW2g at mail dot gmail dot com> <20150525122447 dot 5aafa2da at vepi2> <CAGkQGiLo=KCd8qkvC7OgmWWjjChGYA_7h1KOKv62HwgvUXvpMg at mail dot gmail dot com> <20150527160733 dot 0880b1d2 at vepi2> <5565EFB9 dot 8060901 at sfr dot fr>
On Wed, May 27, 2015 at 06:24:25PM +0200, Mikael Morin wrote:
> Le 27/05/2015 16:07, Andre Vehreschild a ?crit :
> > Hi Paul, hi Mikael,
> >
> > about renaming the identifier emitted: I would like to keep it short. Remember,
> > there is always a number attached to it, which makes it unique. Furthermore
> > does "alloc_source_tmp" sound unnecessarily long to me. It tastes like we do
> > not trust the unique identifier mechanism established in gfortran. But that is
> > just my personal taste.
> >
> Then let's go with "source", which seems to get the majority of the
> votes. It remains an improvement over "expr3" and "atmp".
>
You do realize that expr3 holds things other than the
expression in a source= in an allocate, right?
--
Steve