Re: [patch] testsuite enable PIE tests on FreeBSD

[Jeff Law <law at redhat dot com>]

On 05/25/2015 01:52 PM, Andreas Tobler wrote:
> On 25.05.15 14:42, Dominique Dhumieres wrote:
> > > Wouldn't it be better to remove the target selector and instead add:
> > >
> > > /* { dg-require-effective-target pie } */
> > > ...
> >
> > This allows the tests to be run on Darwin and fail because the code
> > generated does not
> > match the scan-assembler:
> >
> > FAIL: gcc.target/i386/iinline-attr-2.c scan-assembler p2align
> > FAIL: gcc.target/i386/pr32219-1.c scan-assembler movl[
> > \\t]xxx\\\\(%rip\\\\), %eax
> > FAIL: gcc.target/i386/pr32219-3.c scan-assembler movl[
> > \\t]xxx\\\\(%rip\\\\), %eax
> > FAIL: gcc.target/i386/pr32219-3.c scan-assembler-not xxx@GOTPCREL
> > FAIL: gcc.target/i386/pr32219-5.c scan-assembler movl[
> > \\t]xxx\\\\(%rip\\\\), %eax
> > FAIL: gcc.target/i386/pr32219-6.c scan-assembler xxx@GOTPCREL
> > FAIL: gcc.target/i386/pr32219-7.c scan-assembler movl[
> > \\t]xxx\\\\(%rip\\\\), %eax
> > FAIL: gcc.target/i386/pr32219-7.c scan-assembler-not xxx@GOTPCREL
> > FAIL: gcc.target/i386/pr39013-1.c scan-assembler bar@PLT
> > FAIL: gcc.target/i386/pr39013-1.c scan-assembler foo@PLT
> > FAIL: gcc.target/i386/pr39013-2.c scan-assembler bar@PLT
> > FAIL: gcc.target/i386/pr39013-2.c scan-assembler foo@PLT
> >
> > I suspect that this will also be the case for gcc.target/i386/pr64317.c.
>
> Ok. As written on #irc I can exclude *-*-darwin* from the tests with
> this one:
>
> /* { dg-do compile { target { ! { *-*-darwin* } } } } */
>
> Let me know what you prefer.
That should be our fallback depending on Dominique's response to my 
message.

We need to figure out if the expected output needs tweaking or if 
there's some capability these tests expect that isn't available on Darwin.

Sorry you got sucked into the Darwin black hole...  I'll do what I can 
to minimize its effects.


Jeff