This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: acc_on_device for device_type_host_nonshm
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Julian Brown <julian at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Ilya Verbin <iverbin at gmail dot com>
- Date: Thu, 21 May 2015 13:10:05 +0200
- Subject: Re: acc_on_device for device_type_host_nonshm
- Authentication-results: sourceware.org; auth=none
- References: <20150401132025 dot GM19273 at tucnak dot redhat dot com> <20150406124557 dot GA5541 at msticlxl57 dot ims dot intel dot com> <20150407152645 dot GJ19273 at tucnak dot redhat dot com> <20150408153142 dot 128b97b9 at octopus> <20150408145856 dot GA19410 at msticlxl57 dot ims dot intel dot com> <20150414151502 dot 5ca882a4 at octopus> <87pp76zpep dot fsf at schwinge dot name> <20150417131619 dot GP1725 at tucnak dot redhat dot com> <20150507193226 dot 6aee40c5 at octopus> <87h9r6nqh7 dot fsf at kepler dot schwinge dot homeip dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, May 21, 2015 at 01:02:12PM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Thu, 7 May 2015 19:32:26 +0100, Julian Brown <julian@codesourcery.com> wrote:
> > Here's a new version of the patch [...]
>
> > OK for trunk?
>
> Makes sense to me (with just a request to drop the testsuite changes, see
> below), to get the existing regressions under control. Jakub?
Ok for trunk.
>
> > PR libgomp/65742
> >
> > gcc/
> > * builtins.c (expand_builtin_acc_on_device): Don't use open-coded
> > sequence for !ACCEL_COMPILER.
> >
> > libgomp/
> > * oacc-init.c (plugin/plugin-host.h): Include.
> > (acc_on_device): Check whether we're in an offloaded region for
> > host_nonshm
> > plugin. Don't use __builtin_acc_on_device.
> > * plugin/plugin-host.c (GOMP_OFFLOAD_openacc_parallel): Set
> > nonshm_exec flag in thread-local data.
> > (GOMP_OFFLOAD_openacc_create_thread_data): Allocate thread-local
> > data for host_nonshm plugin.
> > (GOMP_OFFLOAD_openacc_destroy_thread_data): Free thread-local data
> > for host_nonshm plugin.
> > * plugin/plugin-host.h: New.
> > * testsuite/libgomp.oacc-c-c++-common/acc_on_device-1.c: Remove
> > -fno-builtin-acc_on_device flag.
> > * testsuite/libgomp.oacc-c-c++-common/if-1.c: Likewise.
> > * testsuite/libgomp.oacc-fortran/acc_on_device-1-1.f90: Remove
> > comment re: acc_on_device builtin.
> > * testsuite/libgomp.oacc-fortran/acc_on_device-1-2.f: Likewise.
> > * testsuite/libgomp.oacc-fortran/acc_on_device-1-3.f: Likewise.> commit adccf2e7d313263d585f63e752a4d36653d47811
Jakub