This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PATCH][ARM] Fix split-live-ranges-for-shrink-wrap.c testcase.


On Wed, 20 May 2015, Alex Velenko wrote:

> Hi,
> 
> This patch limits testcase split-live-ranges-for-shrink-wrap.c runs to
> supported achitecture versions.
> Object size with -march=armv4t check fails because pop pc is not interworking
> safe on armv4t.
> This test is not supported for -march=armv7 as this test is for thumb1.
> 
> Is patch ok?

Again, the condition you propose to add doesn't make sense.  arm_arch_X_ok 
is only appropriate for tests using an explicit -march=X.  Testing with 
-march=armv7* should automatically skip this test anyway because it would 
cause arm_thumb1_ok to fail.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]