This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Paul Koning <Paul_Koning at dell dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Magnus Granberg <zorry at gentoo dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 May 2015 08:37:30 -0700
- Subject: Re: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOrw7OFObOmOCG1wM2Hfr_hpKo-wY0_17ngB89CTQ_34Mw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505072104300 dot 20024 at digraph dot polyomino dot org dot uk> <CAMe9rOrcADb1t2Ch0LDy9SOaS9RDoj4BGgo8qL+6jtg1tnLA8g at mail dot gmail dot com> <3072346 dot CTCrhcXNep at laptop1 dot gw dot ume dot nu> <alpine dot DEB dot 2 dot 10 dot 1505190109380 dot 16300 at digraph dot polyomino dot org dot uk> <CAMe9rOr-mU-vxmF3po-zKAYtLyYGGCN4LeM-DJkL6Kv3fYxD_g at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505191520110 dot 32308 at digraph dot polyomino dot org dot uk> <CAMe9rOqncLsJhb7Fhr3t3acDO+Kq38AeA+ac1TKt6oqWwGz-5Q at mail dot gmail dot com> <C75A84166056C94F84D238A44AF9F6AD173D165C at AUSX10MPS303 dot AMER dot DELL dot COM>
On Tue, May 19, 2015 at 8:33 AM, <Paul_Koning@dell.com> wrote:
>
> ________________________________________
> From: gcc-patches-owner@gcc.gnu.org [gcc-patches-owner@gcc.gnu.org] on behalf of H.J. Lu [hjl.tools@gmail.com]
> Sent: Tuesday, May 19, 2015 11:27 AM
> To: Joseph Myers
> Cc: Magnus Granberg; GCC Patches
> Subject: Re: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option
>
> On Tue, May 19, 2015 at 8:21 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>> ...
>> I think the whole thing should be posted as one patch, with both the
>> target-independent changes and the target-specific changes for all
>> targets.
>>
>
> That is what makes me concerned. I have some simple target-specified
> patches which weren't reviewed for years. What will happen if no one
> reviews some simple target-specified changes due to
>
> 1. Reviewers don't have access to those targets.
> 2. Target maintainers aren't review them.
> 3. There are no clear maintainers for those targets.
>
> As the result, my patch may go nowhere.
> ---
>
> But that hasn't stopped others from posting patches like that, or getting them approved. And we also have global maintainers who can approve things. It feels a bit like a hypothetical issue is being used as a reason to do part of the job.
It is not hypothetical. See:
https://gcc.gnu.org/ml/gcc-patches/2012-09/msg01558.html
It happened before. I don't want to make it harder for global maintainers
to review a patch which has zero-impact on a target if --enable-default-pie
isn't used.
--
H.J.