This is the mail archive of the
mailing list for the GCC project.
Re: [RFA] More type narrowing in match.pd V2
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Marc Glisse <marc dot glisse at inria dot fr>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 18 May 2015 11:17:00 +0200
- Subject: Re: [RFA] More type narrowing in match.pd V2
- Authentication-results: sourceware.org; auth=none
- References: <55441BF2 dot 60703 at redhat dot com> <alpine dot DEB dot 2 dot 02 dot 1505141554100 dot 30908 at stedding dot saclay dot inria dot fr> <5554B11E dot 8090705 at redhat dot com>
On Thu, May 14, 2015 at 4:28 PM, Jeff Law <firstname.lastname@example.org> wrote:
> On 05/14/2015 08:04 AM, Marc Glisse wrote:
>> On Fri, 1 May 2015, Jeff Law wrote:
>>> Slight refactoring of the condition by using types_match as suggested
>>> by Richi. I also applied the new types_match to 2 other patterns in
>>> match.pd where it seemed clearly appropriate.
>> I would like to propose this small tweak (regtested ok). If we had a
>> different type for trees and types, this would be overloading the
>> function. We already do this in a few places, and I find the resulting
>> shorter code more readable.
>> 2015-05-14 Marc Glisse <email@example.com>
>> * generic-match-head.c (types_match): Handle non-types.
>> * gimple-match-head.c (types_match): Likewise.
>> * match.pd: Remove unnecessary TREE_TYPE for types_match.
> Update the comment for types_match and this is fine.
No - it breaks genmatch autodetection of what trees escape. It special-cases
TREE_TYPE (). See capture_info::walk_c_expr:
/* Give up for C exprs mentioning captures not inside TREE_TYPE (). */
unsigned p_depth = 0;
so the patch will pessimize GENERIC folding.
Please do not apply.