This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

From: Jeff Law <law at redhat dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 15 May 2015 13:34:16 -0600
Subject: Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc
Authentication-results: sourceware.org; auth=none
References: <4607191 dot qP5rGA4oDc at polaris> <5554AF5A dot 9030300 at redhat dot com> <6541862 dot MXDvYzObh4 at polaris>

On 05/15/2015 12:39 PM, Eric Botcazou wrote:

You might consider a comment in active_insn_p and
emit_pattern_{after,before}_setloc so that if someone fixes
active_insn_p, they'll know to fix emit_pattern_{after,before}_setloc.
"FIXME" doesn't capture this interaction at all ;-)


I beg to differ, it's the same file and anyone fiddling with JUMP_TABLE_DATA_P
in active_insn_p should do a grep on the file/the entire RTL middle-end.

Fair enough.

Jeff

References:
- Fix RTL checking failure in emit_pattern_{after|before}_setloc
  - From: Eric Botcazou
- Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc
  - From: Jeff Law
- Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]