This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008


 - Youâre missing the match.c part of the patch (I really had a hard time figuring out how the patch was supposed to work! then I read the one posted in the PR)
 - Letâs avoid the strcmp() string comparison and use âop == INTRINSIC_NONEâ as the condition (seems clearer and more efficient to me)
 - Maybe not doing all the tests (those after "The following if-statementsâ) if op == INTRINSIC_NONE, as all the s2 comparisons will be false.
 - The PR number in the ChangeLog is wrong (both times)

With the above fixed, itâs OK.
Thanks for taking care of all this!

FX


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]