This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/7] [D] libiberty: Check symbol length before using strncmp


On 05/13/2015 02:51 AM, Iain Buclaw wrote:
This addresses a subtle logic error, noticed when I was in the middle
of testing out some other tightening up of parsing checks.

---
libiberty/ChangeLog

2015-05-13 Iain Buclaw  <ibuclaw@gdcproject.org>

     * d-demangle.c (dlang_identifier): Check encoded length of identifier
     to verify strncmp matches entire string.
     * testsuite/d-demangle-expected: Fix wrong test for postblit symbols.
That's some pretty obtuse code.  Looks like it's easy to get wrong.

OK.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]