This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [patch, MIPS, testsuite] Fix gcc.target/mips/branch-1.c



> -----Original Message-----
> From: Steve Ellcey [mailto:sellcey@imgtec.com]
> Sent: Monday, May 11, 2015 12:02 PM
> To: gcc-patches@gcc.gnu.org
> Cc: matthew.fortune@imgtec.com; Moore, Catherine
> Subject: [patch, MIPS, testsuite] Fix gcc.target/mips/branch-1.c
> 
> The test gcc.target/mips/branch-1.c has started failing because it is trying to
> verify that each of 4 functions generates and 'andi' instruction and only
> finding 2 of them.  With a recent change (fixing PR 65150) GCC determined
> that the f1 and f2 functions generate identical code and that the f3 and f4
> functions generate identical code and so it replaced f1 with a tail call to f2 and
> f3 with a tail call to f4.  Thus only 2 'andi' instructions show up and the test
> fails.
> 
> There is an existing bug report (PR 65534) about whether or not this is a good
> optimization but I would like to fix this test so that that optimization can not
> happen since that is not what this test is intended to check for.  My solution
> is to pass different arguments to bar() in each function so the code in each
> function is unique.
> 
> Tested with mips-mti-linux-gnu, OK to checkin?
> 
> Steve Ellcey
> sellcey@imgtec.com
> 
> 
> 2015-05-11  Steve Ellcey  <sellcey@mips.com>
> 
> 	* gcc.target/mips/branch-1.c: Pass argument to bar().
> 
> 
This is OK.
Catherine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]