This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fixup libobjc usage of PCC_BITFIELD_TYPE_MATTERS

From: Jeff Law <law at redhat dot com>
To: tbsaunde+gcc at tbsaunde dot org, gcc-patches at gcc dot gnu dot org
Date: Mon, 04 May 2015 11:46:18 -0600
Subject: Re: [PATCH] fixup libobjc usage of PCC_BITFIELD_TYPE_MATTERS
Authentication-results: sourceware.org; auth=none
References: <1430537453-25556-1-git-send-email-tbsaunde+gcc at tbsaunde dot org>

On 05/01/2015 09:30 PM, tbsaunde+gcc@tbsaunde.org wrote:

From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>

Hi,

This adds a configure check to libobjc to find out if types of bitfields effect
their layout, and uses it to replace the rather broken usage of
PCC_BITFIELD_TYPE_MATTERS.

bootstrapped + regtested x86_64-linux-gnu, bootstrapped on ppc64le-linux-gnu
and ran check-objc there without failures, and checked the correct part of the
ifdef is used on a cross to m68k-linux-elf.  ok?  I'm sure I've gotten
something wrong since this is a bunch of auto tools ;-)

Trev

libobjc/ChangeLog:

2015-05-01  Trevor Saunders  <tbsaunde+gcc@tbsaunde.org>

	* acinclude.m4: Include bitfields.m4.
	* config.h.in: Regenerate.
	* configure: Likewise.
	* configure.ac: Invoke gt_BITFIELD_TYPE_MATTERS.
	* encoding.c: Check HAVE_BITFIELD_TYPE_MATTERS.

OK with the general direction here. If Jakub's test is better, then gowith it as a follow-up.


jeff

Follow-Ups:
- [PATCH] Improve the test in bitfields.m4
  - From: tbsaunde+gcc

References:
- [PATCH] fixup libobjc usage of PCC_BITFIELD_TYPE_MATTERS
  - From: tbsaunde+gcc

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]