This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libstdc++ PATCH] Implement observer_ptr
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ed Smith-Rowland <3dw4rd at verizon dot net>
- Cc: Ville Voutilainen <ville dot voutilainen at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Sat, 2 May 2015 10:42:24 +0100
- Subject: Re: [libstdc++ PATCH] Implement observer_ptr
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUaT=BzmzQ=e42OjQz4KT9A1dW+xu+5_gkFMX-DGARJQoQ at mail dot gmail dot com> <20150501210123 dot GN3618 at redhat dot com> <5544303A dot 3010607 at verizon dot net> <20150502094002 dot GQ3618 at redhat dot com>
On 02/05/15 10:40 +0100, Jonathan Wakely wrote:
On 01/05/15 22:02 -0400, Ed Smith-Rowland wrote:
On 05/01/2015 05:01 PM, Jonathan Wakely wrote:
On 01/05/15 16:37 +0300, Ville Voutilainen wrote:
Tested on Linux-x64.
Implement observer_ptr.
Thanks! Committed with some minor formatting changes.
I've also committed this to add feature-test macros and update the
docs. Tested powerpc64le-linux, committed to trunk.
I pretty sure we're supposed to add the macro for *all* the headers
that got enable_if.
That's not how I read the Fundamentals TS:
Programmers who wish to determine whether a feature is available in
an implementation should base that determination on the presence of
the header (determined with __has_include(<header/name>)) and the
state of the macro with the recommended name.
And the header for erase_if is listed as <experimental/vector>.
And SD-6 says:
For library features, the âHeaderâ column identifies the header that
is expected to define the macro, although the macro may also be
predefined.