This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses
- From: Jeff Law <law at redhat dot com>
- To: Mikhail Maltsev <maltsevm at gmail dot com>, gcc-patches <gcc-patches at gnu dot org>, rdsandiford at googlemail dot com
- Date: Tue, 28 Apr 2015 17:52:09 -0600
- Subject: Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses
- Authentication-results: sourceware.org; auth=none
- References: <551A2494 dot 7010906 at gmail dot com> <87wq10bf7c dot fsf at googlemail dot com> <553E975F dot 40601 at gmail dot com>
On 04/27/2015 02:09 PM, Mikhail Maltsev wrote:
I'm sending an updated patch (rebased to recent trunk, bootstrapped and
regtested on x86_64-unknown-linux-gnu).
[ ... ]
-- Regards, Mikhail Maltsev
as_insn2.patch
Needs a ChangeLog. I know it's a bit tedious... But please include it.
It makes patch review easier, and we need one for the ChangeLog file
anyway.
In general, probably more as_a conversions than I'd like. But that may
be unavoidable at this point. On a positive note, I do see some going
away as you strengthen various return and parameter types.
I probably would have done separate patches for the std::swap changes.
They're not really related to the rtx subclasses work.
I'm not sure why you added indention in expand_expr_real_2's switch
statement. It certainly makes the patch harder to review. I'm going to
assume there was a good reason for the new {} pair and added indention.
So I think with a ChangeLog this is ready to go.
jeff