This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 00/12] Reduce conditional compilation

From: Jeff Law <law at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>, Trevor Saunders <tbsaunde at tbsaunde dot org>
Cc: tbsaunde+gcc at tbsaunde dot org, gcc-patches at gcc dot gnu dot org
Date: Wed, 22 Apr 2015 12:36:58 -0600
Subject: Re: [PATCH 00/12] Reduce conditional compilation
Authentication-results: sourceware.org; auth=none
References: <1429622658-9034-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <5536573F dot 4090005 at redhat dot com> <20150421152914 dot GE9945 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com> <1429726381 dot 32584 dot 146 dot camel at surprise>

On 04/22/2015 12:13 PM, David Malcolm wrote:


Conditional compilation was a major PITA when doing the rtx->rtx_insn *
work last year, so I'm very pleased to see these cleanups go in.

Yup. It also got in Andrew's way last year and we regularly see caseswhere small patches which work fine on the mainstream architectures failto build in the lesser used architectures (particularly cc0 targets).It's a whole class of problems I want to see slowly disappear.

glibc went through this process in their codebase for similar reasons,but they had more to lose when they got it wrong -- IIRC they had a casewhere exported ABI would differ as a result of conditionally compiledcode. Not good.


Jeff

Follow-Ups:
- Re: [PATCH 00/12] Reduce conditional compilation
  - From: Trevor Saunders

References:
- [PATCH 00/12] Reduce conditional compilation
  - From: tbsaunde+gcc
- Re: [PATCH 00/12] Reduce conditional compilation
  - From: Jeff Law
- Re: [PATCH 00/12] Reduce conditional compilation
  - From: Trevor Saunders
- Re: [PATCH 00/12] Reduce conditional compilation
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]