This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 00/12] Reduce conditional compilation
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Trevor Saunders <tbsaunde at tbsaunde dot org>
- Cc: Jeff Law <law at redhat dot com>, tbsaunde+gcc at tbsaunde dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 22 Apr 2015 14:13:01 -0400
- Subject: Re: [PATCH 00/12] Reduce conditional compilation
- Authentication-results: sourceware.org; auth=none
- References: <1429622658-9034-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <5536573F dot 4090005 at redhat dot com> <20150421152914 dot GE9945 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com>
On Tue, 2015-04-21 at 11:29 -0400, Trevor Saunders wrote:
> On Tue, Apr 21, 2015 at 07:57:19AM -0600, Jeff Law wrote:
> > On 04/21/2015 07:24 AM, firstname.lastname@example.org wrote:
> > >From: Trevor Saunders <email@example.com>
> > >
> > >Hi,
> > >
> > >This is a first round of patches to reduce the amount of code with in #if /
> > >#ifdef. This makes it incrementally easier to not break configs other than the
> > >one being built, and moves things slightly closer to using target hooks for
> > >everything.
> > >
> > >each commit bootstrapped and regtested on x86_64-linux-gnu without regression,
> > >and whole patch set run through config-list.mk without issue, ok?
> > So I think after looking at this patchset, any changes of a similar nature
> > you want to make should be considered pre-approved. Just post them for
> > archival purposes, but no need for you to wait for review as long as they
> > have the same purpose and overall structure as was seen in these patches.
> thanks! Its also always nice to have someone double check your logic
Thanks for working on this!
Conditional compilation was a major PITA when doing the rtx->rtx_insn *
work last year, so I'm very pleased to see these cleanups go in.