This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for PR65729


On 15/04/15 13:51, Yvan Roux wrote:
> Hi,
> 
> On 14 April 2015 at 17:36, Vladimir Makarov <vmakarov@redhat.com> wrote:
>> On 04/14/2015 04:11 AM, Jakub Jelinek wrote:
>>>
>>> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote:
>>>>
>>>> --- a/gcc/lra-constraints.c
>>>> +++ b/gcc/lra-constraints.c
>>>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class
>>>> rclass,
>>>>   {
>>>>     HARD_REG_SET temp;
>>>>     -  // ??? Is this assert right
>>>> -  // lra_assert (hard_reg_set_subset_p (set,
>>>> reg_class_contents[rclass]));
>>>> +  lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set));
>>>
>>> Missing space after ,
>>> Otherwise, I'll defer to Vlad for review.
>>>
>>>
>> The patch is ok for me to commit it into the trunk.  Thanks, Yvan.
> 
> The testcase needs the hard float ABI support, and can fail if tested
> in a way the -march=armv7-a  is overridden.  This patch patch restrict
> the test to hard vfp compliant targets.  Ok for trunk ?
> 
> Thanks,
> Yvan
> 
> 2015-04-15  Yvan Roux  <yvan.roux@st.com>
> 
>     * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets.
> 

OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]