This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/65780: [5/6 Regression] Uninitialized common handling in executables
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Apr 2015 23:44:47 +0200
- Subject: Re: [PATCH] PR target/65780: [5/6 Regression] Uninitialized common handling in executables
- Authentication-results: sourceware.org; auth=none
- References: <20150416185748 dot GA28126 at intel dot com> <55313103 dot 3030200 at redhat dot com> <CAMe9rOp4+H7mc+it-ppjGqx3qP6GZOMrfGGyR4cisbrQTAtReA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Apr 17, 2015 at 02:38:01PM -0700, H.J. Lu wrote:
>
Please add
PR target/65780
line to the ChangeLog entry. Ok for trunk and 5 branch with that change,
thanks.
> * config/i386/i386.c (ix86_binds_local_p): Define only if
> TARGET_MACHO and TARGET_DLLIMPORT_DECL_ATTRIBUTES are false.
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index da69186..d870ab8 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -51737,6 +51737,7 @@ ix86_initialize_bounds (tree var, tree lb, tree ub, tree *stmts)
> return 2;
> }
>
> +#if !TARGET_MACHO && !TARGET_DLLIMPORT_DECL_ATTRIBUTES
> /* For i386, common symbol is local only for non-PIE binaries. For
> x86-64, common symbol is local only for non-PIE binaries or linker
> supports copy reloc in PIE binaries. */
> @@ -51749,6 +51750,7 @@ ix86_binds_local_p (const_tree exp)
> || (TARGET_64BIT
> && HAVE_LD_PIE_COPYRELOC != 0)));
> }
> +#endif
>
> /* Initialize the GCC target structure. */
> #undef TARGET_RETURN_IN_MEMORY
Jakub