This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Thomas Schwinge <thomas at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Wed, 8 Apr 2015 17:58:56 +0300
- Subject: Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)
- Authentication-results: sourceware.org; auth=none
- References: <20150331125206 dot GC64930 at msticlxl57 dot ims dot intel dot com> <20150331130758 dot GA19273 at tucnak dot redhat dot com> <20150331161036 dot GA623 at msticlxl57 dot ims dot intel dot com> <20150331235328 dot GC623 at msticlxl57 dot ims dot intel dot com> <20150401052147 dot GG19273 at tucnak dot redhat dot com> <20150401131405 dot GD623 at msticlxl57 dot ims dot intel dot com> <20150401132025 dot GM19273 at tucnak dot redhat dot com> <20150406124557 dot GA5541 at msticlxl57 dot ims dot intel dot com> <20150407152645 dot GJ19273 at tucnak dot redhat dot com> <20150408153142 dot 128b97b9 at octopus>
On Wed, Apr 08, 2015 at 15:31:42 +0100, Julian Brown wrote:
> This version is mostly the same as the last posted version but has a
> tweak in GOACC_parallel to account for the new splay tree arrangement
> for target functions:
>
> - tgt_fn = (void (*)) tgt_fn_key->tgt->tgt_start;
> + tgt_fn = (void (*)) tgt_fn_key->tgt_offset;
>
> Have there been any other changes I might have missed?
No.
> It passes libgomp testing on NVPTX. OK?
Have you tested it with disabled offloading?
I see several regressions:
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/acc_on_device-1.c -DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/if-1.c -DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test
-- Ilya