This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
- From: Caroline Tice <cmtice at google dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 31 Mar 2015 08:12:43 -0700
- Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)
- Authentication-results: sourceware.org; auth=none
- References: <CABtf2+QZP3Y7f+x075fKDxjaX7PGiAirV87ajML2nJpfnoz5BA at mail dot gmail dot com> <548612F0 dot 8050209 at redhat dot com> <CABtf2+Ro9jO7Mfm0hrjCMV4x5UROhVTHzQY3jE7Fiw=zrb8faA at mail dot gmail dot com> <551A2E69 dot 3070106 at redhat dot com>
I am fine with waiting until stage 1. When that is likely to be?
-- Caroline Tice
cmtice@google.com
On Mon, Mar 30, 2015 at 10:19 PM, Jeff Law <law@redhat.com> wrote:
> On 03/27/2015 10:44 AM, Caroline Tice wrote:
>>
>> It took me a while to get a test case I'm happy with, so I'm
>> re-submitting the whole patch for approval.
>>
>> 2015-03-27 Caroline Tice <cmtice@google.com>
>>
>> * final.c (final_scan_insn): Change 'cold_function_name' to
>> 'cold_partition_name' and make it a global variable; also output
>> assembly to give it a 'FUNC' type, if appropriate.
>> * varasm.c (cold_partition_name): Declare and initialize global
>> variable.
>> (assemble_start_function): Re-set value for cold_partition_name.
>> (assemble_end_function): Output assembly to calculate size of
>> cold
>> partition, and associate size with name, if appropriate.
>> * varash.h (cold_partition_name): Add extern declaration for
>> global
>> variable.
>> * testsuite/gcc.dg/tree-prof/cold_partition_label.c: Add
>> dg-final-use
>> to scan assembly for cold partition name and size.
>
> Given we're late in stage4, can this wait until stage1, where it should be
> considered pre-approved? I'd hate to mess up the PA or PTX ports at this
> stage in the release process.
>
> jeff
>