This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] New testcase to check parameter passing bug
- From: Honggyu Kim <hong dot gyu dot kim at lge dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: 'Jeff Law' <law at redhat dot com>, gcc-patches at gcc dot gnu dot org, segher at kernel dot crashing dot org, christophe dot lyon at st dot com, mikpelinux at gmail dot com
- Date: Sun, 29 Mar 2015 20:36:16 +0900
- Subject: Re: [PATCH v2] New testcase to check parameter passing bug
- Authentication-results: sourceware.org; auth=none
- References: <55096746 dot 4080404 at arm dot com> <1426729244-12509-1-git-send-email-hong dot gyu dot kim at lge dot com> <5512A9B1 dot 1080104 at redhat dot com> <000401d06704$c4cd8dc0$4e68a940$ at arm dot com>
On Wed, Mar 25, 2015 at 02:05:37PM -0000, Kyrill Tkachov wrote:
>
>
> > -----Original Message-----
> > From: Jeff Law [mailto:law@redhat.com]
> > Sent: 25 March 2015 12:27
> > To: Honggyu Kim; gcc-patches@gcc.gnu.org
> > Cc: Kyrylo Tkachov; segher@kernel.crashing.org; christophe.lyon@st.com
> > Subject: Re: [PATCH v2] New testcase to check parameter passing bug
> >
> > On 03/18/15 19:40, Honggyu Kim wrote:
> > > Hi,
> > >
> > > I have modified the test-case to check parameter passing bug based on
> > > the comments from Kyrill Tkachov, Christophe Lyon, and Segher
> > > Boessenkool as follows:
> > > 1. move from "gcc.target/arm" to "gcc.dg"
> > > 2. change "dg-do compile" to "dg-do run"
> > >
> > > Please let me know if there's still something to fix more.
> > > Thanks for your comment.
> > >
> > > Honggyu
> > > ---
> > > gcc/testsuite/ChangeLog | 4 ++++
> > > gcc/testsuite/gcc.dg/pr65358.c | 33
> > +++++++++++++++++++++++++++++++++
> > > 2 files changed, 37 insertions(+)
> > > create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
> > >
> > > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index
> > > 77d24a1..218f908 100644
> > > --- a/gcc/testsuite/ChangeLog
> > > +++ b/gcc/testsuite/ChangeLog
> > > @@ -1,3 +1,7 @@
> > > +2015-03-19 Honggyu Kim <hong.gyu.kim@lge.com>
> > > +
> > > + * gcc.dg/pr65358.c: New test.
> > This should be included as part of Kyrill's patch. If the test goes in
> without
> > Kryill's fix, then it'll just create testsuite noise.
>
> I'll make sure to commit this together with my fix (at
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01014.html)
> if it gets approved. I agree that there's no point taking the test in by
> itself .
>
> Thanks,
> Kyrill
>
> >
> > Jeff
> >
I have tested Kyrill's patch and it works fine.
Thanks for all your comments.
Especially, Mikael Pettersson's help for this testcase.
Honggyu