This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [debug-early] Remove redundant argument to add_subscript_info


On 03/26/2015 12:16 PM, Aldy Hernandez wrote:
Is there a reason we pass a collapsible option to add_subscript_info? It
seems like it's value is always !is_ada().  Can we just get rid of the
argument, and calculate its value within the function, or was it there
for some future flexibility?

On trunk, this is calculated in one place, in gen_array_type_die, and it's passed down for consistency. I'd rather not change it to be calculated in multiple places, as in this patch. I would be fine, however, with changing collapse_nested_arrays to a function that returns !is_ada().

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]