This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [debug-early] Handle specification of class scoped static functions

From: Aldy Hernandez <aldyh at redhat dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 20 Mar 2015 17:11:44 -0700
Subject: Re: [debug-early] Handle specification of class scoped static functions
Authentication-results: sourceware.org; auth=none
References: <550C5F3A dot 1030802 at redhat dot com> <550C8F4C dot 1020003 at redhat dot com>

On 03/20/2015 02:21 PM, Jason Merrill wrote:

I think we want to drop the debug_early check there entirely; the added
conditions seem to be gutting it.  If is_cu_die (old_die->die_parent) is
false, then class_or_namespace_scope_p (old_die->die_parent) ought to be
true.

Jason

Good catch. I am so glad you are keeping track of all this spaghetti,but in my defense, it was pasta already.

With the attached I also got rid of one superfluous check for `old_die',as well as your suggestion. We get rid of one more gdb regression. Yay.


I'll wait for your high-five (or OK) before committing to branch.

Thanks.
Aldy

Attachment: curr
Description: Text document

References:
- [debug-early] Handle specification of class scoped static functions
  - From: Aldy Hernandez
- Re: [debug-early] Handle specification of class scoped static functions
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]