This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Wed, 18 Mar 2015 12:11:31 -0700
- Subject: Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work
- Authentication-results: sourceware.org; auth=none
- References: <20150306013151 dot GA19444 at intel dot com> <20150306134217 dot GA21141 at intel dot com> <CAFULd4bjUGRunFtepHF+cTOeX06J2boL2XTs1dnThAtPx2SAJA at mail dot gmail dot com> <91A78199-CD95-4074-8FD3-72D193898EDF at comcast dot net>
On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump <mikestump@comcast.net> wrote:
> On Mar 18, 2015, at 2:55 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>>> Here is the updated patch with testcases. Tested on Linux/x86. OK
>>> for trunk?
>
>> This patch needs global reviewer approval (I have added Jakub to CC)
>> and Darwin maintainer approval.
>
> So, my concern would be this, does the bug also impact darwin, and does the bug fix also fix darwin?
This bug doesn't impact darwin.
> If no and the change doesnât change code-gen for darwin (which I think it does not), then the darwin bits are ok.
>
> I did a quick check of the test case on darwin, no protected variables (we ignore the protected request). When compiled, the program works (returns 0).
It is expected. This bug only affects targets which support protected
visibility and use copy relocation.
--
H.J.