This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work


On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump <mikestump@comcast.net> wrote:
> On Mar 18, 2015, at 2:55 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>>> Here is the updated patch with testcases.  Tested on Linux/x86.  OK
>>> for trunk?
>
>> This patch needs global reviewer approval (I have added Jakub to CC)
>> and Darwin maintainer approval.
>
> So, my concern would be this, does the bug also impact darwin, and does the bug fix also fix darwin?

This bug doesn't impact darwin.

> If no and the change doesnât change code-gen for darwin (which I think it does not), then the darwin bits are ok.
>
> I did a quick check of the test case on darwin, no protected variables (we ignore the protected request).  When compiled, the program works (returns 0).

It is expected.  This bug only affects targets which support protected
visibility and use copy relocation.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]