This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR64748
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Jeff Law <law at redhat dot com>, James Norris <jnorris at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Mar 2015 16:28:15 +0100
- Subject: Re: [PATCH] Fix PR64748
- Authentication-results: sourceware.org; auth=none
- References: <54E23658 dot 6060105 at codesourcery dot com> <54FEF37B dot 8090405 at codesourcery dot com> <54FF3C82 dot 2080201 at redhat dot com> <87r3ss53ae dot fsf at kepler dot schwinge dot homeip dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Mar 13, 2015 at 04:24:09PM +0100, Thomas Schwinge wrote:
> Hi Jeff!
>
> On Tue, 10 Mar 2015 12:48:34 -0600, Jeff Law <law@redhat.com> wrote:
> > On 03/10/15 07:36, James Norris wrote:
> > > Ping.
> > Note that the GCC trunk is in regression bugfix stage, so this patch may
> > (is likely?) be deferred until the next stage1 development cycle.
>
> The decision is with you guys, but my understanding has been, that we can
> still apply bug fixes to (new) OpenACC code (Jim's patch is a bug fix),
> and possibly even extend the OpenACC code (which has not been part of a
> GCC release before, so can't regress).
Yeah, it is acceptable, but as you noted, formatting should be fixed and
also ensure that the same error isn't reported multiple times.
For OpenMP, generally most of the diagnostics that isn't related to parsing
clauses is deferred until *finish_omp_clauses, where after diagnosing
something on a clause the clause is removed and so not reported again later.
Jakub