Re: [PATCH, stage1] Make parloops gate more strict

[Richard Biener <richard dot guenther at gmail dot com>]

On Fri, Mar 13, 2015 at 12:12 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 13-03-15 11:36, Richard Biener wrote:
>>
>> On Fri, Mar 13, 2015 at 11:32 AM, Tom de Vries <Tom_deVries@mentor.com>
>> wrote:
>>>
>>> Hi,
>>>
>>> this patch moves a bunch of early-out tests from the parloops pass to the
>>> gate function.
>>>
>>> The only effect is for functions that we don't consider at all for
>>> parallelization in the parloops pass. We no longer dump those in the
>>> parloops dump file.
>>>
>>> Bootstrapped and reg-tested on x86_64.
>>>
>>> OK for stage1 trunk?
>>
>>
>> Does it work with -fdump-passes?
>
>
> Hmm, I never heard of the option, interesting, thanks.
>
> Let's see what it is supposed to do:
> ...
> @item -fdump-passes
> @opindex fdump-passes
> Dump the list of optimization passes that are turned on and off by
> the current command-line options.
> ...
>
> fdump-passes seems to be using the gate function to find out the effect of
> the command line options on the pass.
>
> But then f.i. in pass_stdarg, using fun->stdarg in the gate function
> violates that AFAIU.
>
> Does this mean the gate function of pass_stdarg should be fixed by moving
> the fun->stdarg test from the gate to the execute function?

Not really (I don't like -fdump-passes ...), but we need to make sure
that -fdump-passes doesn't crash (because it runs very early and
with cfun == NULL I think)

Richard.

> Thanks,
> - Tom