This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR44563 more
- From: Richard Biener <rguenther at suse dot de>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Mar 2015 09:40:23 +0100 (CET)
- Subject: Re: [PATCH] Fix PR44563 more
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1503101154040 dot 10796 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1503121121370 dot 10796 at zhemvz dot fhfr dot qr> <20150313071107 dot GA27617 at atrey dot karlin dot mff dot cuni dot cz>
On Fri, 13 Mar 2015, Jan Hubicka wrote:
> > >
> > > Honza - I think we performed this in CFG cleanup for the sake of CFG
> > > checking, not for the sake of prompt optimization, no?
>
> Aha, now I understand what you ask about. I guess it can be seen this way.
> NORETURN calls are CFG altering and veriy_flow_infowould indeed bomb.
Yeah, but nowadays (on the GIMPLE level) the noreturn calls are _not_
control altering until you set the GF_CALL_CTRL_ALTERING flag on it.
The verifying on bogus lhs of noreturn calls probably should be
guarded the same way.
So it's no longer necessary to immediately fixup noreturn calls
(but it's of course nice for optimization and compile-time reasons).
Richard.