This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, MIPS] Fix PR 58158 - ICE on MIPS Loongson
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Steve Ellcey <Steve dot Ellcey at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: "clm at codesourcery dot com" <clm at codesourcery dot com>
- Date: Mon, 2 Mar 2015 23:54:57 +0000
- Subject: RE: [Patch, MIPS] Fix PR 58158 - ICE on MIPS Loongson
- Authentication-results: sourceware.org; auth=none
- References: <0ae8c7b1-c03c-4454-a7e3-59ce166330ee at BAMAIL02 dot ba dot imgtec dot org>
Thanks for looking through and catching this.
I had conflicting thoughts on whether the new condition should
reference both !ISA_HAS_FP_CONDMOVE || ISA_HAS_SEL but if we take it
that FP_CONDMOVE is the only way to get an integer conditional
move based on an FP condition then that's fine.
> 2015-03-02 Steve Ellcey <sellcey@imgtec.com>
>
> PR target/58158
> * config/mips/mips.md (mov<mode>cc): Change ISA_HAS_SEL check to
> !ISA_HAS_FP_CONDMOVE.
OK.
Are you planning on doing any backports of this patch to release
branches?
Thanks,
Matthew