This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] ICF is more strict about non-common function and var, attributes.
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, "gcc-pat >> GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 1 Mar 2015 00:57:46 +0100
- Subject: Re: [PATCH] ICF is more strict about non-common function and var, attributes.
- Authentication-results: sourceware.org; auth=none
- References: <54F23BFA dot 4060502 at suse dot cz> <20150228224223 dot GD20437 at kam dot mff dot cuni dot cz> <54F2554D dot 5080109 at suse dot cz>
>
> Half of FAILs are gone, but the rest is correctly merged (alignment matches). Thus I would omit ICF
> in this testcase. I'm going to install the patch.
>
> Thanks,
> Martin
> >From 60c5fdc5d5bab2d26a43813ffebda247c8dd1fce Mon Sep 17 00:00:00 2001
> From: mliska <mliska@suse.cz>
> Date: Fri, 27 Feb 2015 21:49:46 +0100
> Subject: [PATCH 1/4] ICF is more strict about non-common function and var
> attributes.
>
> gcc/ChangeLog:
>
> 2015-02-28 Martin Liska <mliska@suse.cz>
> Jan Hubicka <hubicka@ucw.cz>
>
> * ipa-icf-gimple.c (func_checker::compare_variable_decl):
> Validate variable alignment.
> * ipa-icf.c (sem_function::equals_private): Be more precise
> about non-common function attributes.
> (sem_variable::equals): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2015-03-01 Martin Liska <mliska@suse.cz>
> Jan Hubicka <hubicka@ucw.cz>
>
> * gcc.target/i386/stackalign/longlong-2.c: Omit ICF.
OK then.
Thanks! Are we ready to close the PR?
Honza