This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C/C++ PATCH] -Wlogical-not-parentheses tweaks (PR c/65120)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 27 Feb 2015 17:29:47 -0500
Subject: Re: [C/C++ PATCH] -Wlogical-not-parentheses tweaks (PR c/65120)
Authentication-results: sourceware.org; auth=none
References: <20150220000326 dot GT1746 at tucnak dot redhat dot com>

On 02/19/2015 07:03 PM, Jakub Jelinek wrote:

+	  /* Avoid warning for !!b == y where b is boolean.  */
+	  && (!DECL_P (current.lhs)
+	      || TREE_TYPE (current.lhs) == NULL_TREE
+	      || TREE_CODE (TREE_TYPE (current.lhs)) != BOOLEAN_TYPE))

There's something wrong here. If the type is null, trying to check itsTREE_CODE will SEGV.


Jason

References:
- [C/C++ PATCH] -Wlogical-not-parentheses tweaks (PR c/65120)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]