This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for PR ipa/64693
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 27 Feb 2015 17:58:09 +0100
- Subject: Re: [PATCH] Fix for PR ipa/64693
- Authentication-results: sourceware.org; auth=none
- References: <54DC77A5 dot 4020409 at suse dot cz> <20150212165758 dot GA3301 at kam dot mff dot cuni dot cz> <54E7308B dot 3020400 at suse dot cz> <20150220183956 dot GD21632 at kam dot mff dot cuni dot cz> <54EDF616 dot 9070908 at suse dot cz> <20150225170043 dot GB52956 at kam dot mff dot cuni dot cz> <54EE1027 dot 6090700 at suse dot cz> <20150226182104 dot GD13748 at kam dot mff dot cuni dot cz> <54F08FA5 dot 8070801 at suse dot cz>
> Hi.
>
> There's one missing vector comparison. Fix is obvious, ready for trunk?
>
> Thanks,
> Martin
> >From 3d03fb28ec21b6ed30d5179bd70aba79d246cd26 Mon Sep 17 00:00:00 2001
> From: mliska <mliska@suse.cz>
> Date: Fri, 27 Feb 2015 16:35:31 +0100
> Subject: [PATCH] Fix missing condition in symbol_compare_hashmap_traits.
>
> gcc/ChangeLog:
>
> 2015-02-27 Martin Liska <mliska@suse.cz>
>
> * ipa-icf.h (struct symbol_compare_hashmap_traits): Add missing
> vector length condition.
OK
Honza
> ---
> gcc/ipa-icf.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/ipa-icf.h b/gcc/ipa-icf.h
> index 9e76239..077267c 100644
> --- a/gcc/ipa-icf.h
> +++ b/gcc/ipa-icf.h
> @@ -110,7 +110,8 @@ struct symbol_compare_hashmap_traits: default_hashmap_traits
> equal_keys (const symbol_compare_collection *a,
> const symbol_compare_collection *b)
> {
> - if (a->m_references.length () != b->m_references.length ())
> + if (a->m_references.length () != b->m_references.length ()
> + || a->m_interposables.length () != b->m_interposables.length ())
> return false;
>
> for (unsigned i = 0; i < a->m_references.length (); i++)
> --
> 2.1.2
>