This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ICE in early inliner (PR ipa/65008)


> > > Are cgraph edges up-to-date here?  I'd doubt that...  if so, why not
> > > do this update in the inliner itself where it updates the cgraph edges?

And for Richard's comment - edges are kept up-to-date by the inliner - that is
also necessary for clonning and other stuff.
Parameters are not kept up to doate though, because only early inliner needs to
preserve them for this iteration.  I think it is easier to deal with this in early
inliner than adding yet another special case to tree-inline.

Honza
> > 
> > I've tried to move this hunk into tree-inliner.c, but I think that is
> > not possible.  E.g. inline_edge_summary is ipa-inline thing only.
> > Also all my attemps to update the inline metrics somewhere in copy_bb or
> > e.g. expand_call_inline failed, so I'm afraid I don't have anything
> > better than the original patch ;).  Honza, any opinion?
> > 
> > 	Marek
> 
> 	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]