This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 25 Feb 2015 21:57:39 -0500
- Subject: Re: [PATCH] rs6000: Fix HTM tcheck assembly encoding
- Authentication-results: sourceware.org; auth=none
- References: <54E7728B dot 1040706 at linux dot vnet dot ibm dot com> <CAGWvnyn+Gnb62ZreyF=4p70hCFaqeiisJK5vbVdxDWY8bYRVow at mail dot gmail dot com> <1424715961 dot 7396 dot 121 dot camel at otta> <CAGWvny=7_+MM_9YYxfyhYM2YF7MpOCEYyO7ka13tZf_Eue_W8Q at mail dot gmail dot com> <1424918533 dot 7396 dot 164 dot camel at otta>
On Wed, Feb 25, 2015 at 9:42 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote:
>> Again, a testcase is highly encouraged.
>
> Actually, this additional change to the test case would be enough
> to have the assembler catch the bad opcode mnemonic. Should I
> just go ahead and make this change?
>
> I still plan on adding a test case that actually executes when
> we're on power8.
>
> Peter
>
>
> Index: gcc.target/powerpc/htm-builtin-1.c
> ===================================================================
> --- gcc.target/powerpc/htm-builtin-1.c (revision 220992)
> +++ gcc.target/powerpc/htm-builtin-1.c (working copy)
> @@ -1,7 +1,7 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do assemble { target { powerpc*-*-* } } } */
> /* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
> /* { dg-require-effective-target powerpc_htm_ok } */
> -/* { dg-options "-O2 -mhtm" } */
> +/* { dg-options "-O2 -mhtm -save-temps" } */
>
> /* { dg-final { scan-assembler-times "tbegin\\." 1 } } */
> /* { dg-final { scan-assembler-times "tend\\." 2 } } */
> @@ -49,3 +49,4 @@ void use_builtins (long *p, char code, l
> __builtin_set_tfhar (a[22]);
> __builtin_set_tfiar (a[23]);
> }
> +/* { dg-final { cleanup-saved-temps } } */
Okay.
Thanks, David