This is the mail archive of the
mailing list for the GCC project.
Re: Patch ping
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Feb 2015 17:28:21 +0100
- Subject: Re: Patch ping
- Authentication-results: sourceware.org; auth=none
- References: <5454CAB9 dot 3040907 at codesourcery dot com> <20150204113817 dot GO1746 at tucnak dot redhat dot com> <CAFiYyc11FF2EeOQzqVmQu=q9-Uh-YCN0e38jUn-jmhD9gUrWsw at mail dot gmail dot com> <20150216210812 dot GO1746 at tucnak dot redhat dot com> <5388429A-DE44-4C08-8A19-D42B6E00C0A6 at gmail dot com> <20150216214349 dot GR1746 at tucnak dot redhat dot com> <CAFiYyc3U-CLmDxv=-8AKaJ7xD5G86ctsUsOJnMvPcNEfHR3JFg at mail dot gmail dot com> <20150218100035 dot GF1746 at tucnak dot redhat dot com> <20150225070010 dot GS1746 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1502251006530 dot 28824 at zhemvz dot fhfr dot qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 25, 2015 at 10:10:52AM +0100, Richard Biener wrote:
> Oops, totally forgot about this one.
> + default:
> + error ("unsupported mode %s\n", mname);
> be a fatal_error ()? After all if we hit this but continue we'll
Ok, I'll change it.
> stream random crap. I also think we should be a bit more user-centric
> here and maybe report "for host / offload target combination".
Eventually, sure, we should be able (based on options) either turn all the
errors from the offloading compiler into warnings that just disable the
offloading for some particular offloading target.
> +static GTY(()) const unsigned char *lto_mode_identity_table;
> why in GC memory?
The reason for that is that it is referenced from GC structure, and in the
offloading path they should be GC allocated, so that they can be released
when the corresponding GC structure holding pointer to that goes away.
In the non-offloading LTO, all those GC structures will contain the same
value, lto_mode_identity_table, but if that would be heap allocated, GC
would be upset.