This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney


On Wed, Feb 25, 2015 at 01:42:39PM +0000, Xingxing Pan wrote:
> Hi,
> 
> This patch expanding the following RTL types. And it has been merged to the latest code base.
> 
>          (neon_logic): Expand to neon_logic_reg and neon_logic_imm.
>          (neon_logic_q): Expand to neon_logic_reg_q and neon_logic_imm_q.
>          (neon_from_gp): Expand to neon_from_gp and neon_from_gp_scalar.
>          (neon_from_gp_q): Expand to neon_from_gp_q and neon_from_gp_scalar_q.
>          (neon_to_gp): Expand to neon_to_gp and neon_to_gp_scalar.
>          (neon_to_gp_q): Expand to neon_to_gp_q and neon_to_gp_scalar_q.
> 
> Is it OK for trunk?
> 
> -- 
> Regards,
> Xingxing

I've had a look through the AArch64 parts, and they look OK to me
(though only Marcus or Richard can approve them), I have one additional
comment.

>  ;; In this insn, operand 1 should be low, and operand 2 the high part of the
> diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
> index 8f157ce..8be2ebf 100644
> --- a/gcc/config/aarch64/aarch64.md
> +++ b/gcc/config/aarch64/aarch64.md
> @@ -828,7 +828,7 @@
>       }
>  }
>    [(set_attr "type" "mov_reg,mov_imm,mov_imm,load1,load1,store1,store1,\
> -                     neon_from_gp<q>,neon_from_gp<q>, neon_dup")
> +                     neon_to_gp_scalar<q>,neon_from_gp<q>, neon_dup")
>     (set_attr "simd" "*,*,yes,*,*,*,*,yes,yes,yes")]
>  )

Here you change neon_from_gp<q> to neon_to_gp_scalar<q>.

This looks like the correct thing to do, but would you mind pulling it out
to a separate patch, first changing neon_from_gp<q> to neon_to_gp<q>?

I'd just like to have the bug-fix separate from the bigger infrastructure
change.

Thanks,
James


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]