This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH/AARCH64] Fix gcc.c-torture/compile/pr37433.c for AARCH64:ILP32.
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 24 Feb 2015 21:39:37 -0800
- Subject: Re: [PATCH/AARCH64] Fix gcc.c-torture/compile/pr37433.c for AARCH64:ILP32.
- Authentication-results: sourceware.org; auth=none
- References: <CA+=Sn1k+xjTm-9cCUF0yJHfr7H18HRyP72=NwsDDnNvMP+uGYg at mail dot gmail dot com> <CAFqB+PwGMBJvJHMW5dgBcPqKvDXjMKQH+8J2f-zshP0=mZxq1w at mail dot gmail dot com> <54ED5B0C dot 8030203 at redhat dot com>
On Tue, Feb 24, 2015 at 9:18 PM, Jeff Law <email@example.com> wrote:
> On 02/17/15 08:31, Marcus Shawcroft wrote:
>> On 9 February 2015 at 05:41, Andrew Pinski <firstname.lastname@example.org> wrote:
>>> The problem here is that we get a symbol_ref which is SImode but for
>>> the sibcall patterns we only match symbol_refs which use DImode. I
>>> added a new testcase that tests the non-value sibcall pattern too.
>>> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.
>> Why are we being given an SI mode expression here, I would have
>> thought we should get FUNCTION_MODE or Pmode ?
> Agreed. I guess something might be doing something weird and generating the
> SImode from POINTER_SIZE.
> I was going to look for that since it seemed so weird, but I've been unable
> to reproduce this failure with the tip of the trunk or a variety of trees
> from around the date this bug was reported.
Weird as I did not have any changes in my tree at the time I reported
it. I was bootstrapping a clean trunk.
> Andrew, is it possible you had some local changes in your tree that were
> responsible for getting the bogus mode? What were the flags you used to
> trigger the failure?
I will try again, I might have messed up something but I knew I saw
this at one time and even when I was patching the sources myself.
> I tried it with -mabi=ilp32 using the standard c-torture options.