This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()

On 2/25/15 07:36, wrote:
> On Tue, Feb 24, 2015 at 2:05 PM, Max Filippov <> wrote:
>> Hi,
>> On Tue, Feb 24, 2015 at 6:54 PM, Jeff Law <> wrote:
>>> You can tackle them in any order you wish.  However, I suspect fixing the
>>> xtensa backend may be easier.  I don't have any good way to test xtensa, but
>>> something like the attached patch for the xtensa port should be sufficient.
>> I can confirm that this patch fixes the issue. I haven't got a segfault
>> as was reported in bugzilla, but I got some 'conditional jump or move
>> depends on uninitialised value' under valgrind, originated from
>> find_reloads, that the patch fixed. And with it the testcase from
>> bugzilla actually produces code with loop instruction.
> Max, the patch doesn't fix the underlying issue, it just hides the bad
> memory reference by initializing what we were already accessing.
> See Jeff Law's message earlier in the thread.

So we need genrecog to find the underlying issue in time, and report
error (stop building gcc).

And also thank Max very much for his warmhearted response in every where
(kernel, qemu, and gcc). I am sure your response will give much help to
me. :-)

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]